Add integration test for FastTransforms #86
Conversation
|
@devmotion this is ready for review. I had to hackily fix FFTW at v1.5 for the FastTransforms.jl test to account for JuliaApproximation/FastTransforms.jl#192 / JuliaApproximation/FastTransforms.jl#193, but I'll remove it ASAP once those are sorted out. |
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## master #86 +/- ##
==========================================
+ Coverage 84.13% 87.08% +2.94%
==========================================
Files 2 3 +1
Lines 208 209 +1
==========================================
+ Hits 175 182 +7
+ Misses 33 27 -6 see 4 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report in Codecov by Sentry. |
|
Hmm this workaround is annoying and I'm worried we'll forget to remove it. We could merge and open an issue in AbstractFFTs about removing it, but given that the iaaue was only reported yesterday and the PR is not completely urgent, maybe it's easier to just wait until it is fixed in FastTransforms? |
|
I'm fine with that as long as this doesn't block #84 -- shall we satisfy ourselves with local tests there for now? |
|
Looks ready for merge |
2 participants
No description provided.